Small bug in lv_bmp.c

General discussion
1

Tried to display a 24bpp bmp file with LV_COLOR_DEPTH = 32, this failed and gave this warning:

[Warn] (10.225, +11) decoder_open: LV_COLOR_DEPTH == 32 but bpp is 24 (should be 32 or 24) (in lv_bmp.c line #156)

Checking line 156:

        if(LV_COLOR_DEPTH == 32 && (b.bpp != 32 || b.bpp != 24)) {
            LV_LOG_WARN("LV_COLOR_DEPTH == 32 but bpp is %d (should be 32 or 24)", b.bpp);
            color_depth_error = true;
        }

b.bpp can’t be both 32 and 24 at the same time, so the condition in parenthesis will always return true when bpp is 32 and when bpp is 24 and cause a fail…the || should be &&

2

Fixed; thank you!

3

i think i got it, || → &&