Long Pressed Repeat is called, but not Long Pressed

SgtPepperFTW · December 21, 2023, 7:37pm

lv_group_remove_all_objs(lv_group_get_default());
    lv_group_add_obj(lv_group_get_default(), lv_scr_act());
    lv_obj_add_event_cb(lv_scr_act(), poweron_long_press_cb, LV_EVENT_LONG_PRESSED, this);
    lv_obj_add_event_cb(lv_scr_act(), poweron_long_press_repeat_cb, LV_EVENT_LONG_PRESSED_REPEAT, this);

With this code, long pressing encoder, the poweron_long_press_repeat_cb is called, but not poweron_long_press_cb. Any ideas? P.S. Tried to change LV_INDEV_DEF_LONG_PRESS_REP_TIME to be bigger than LV_INDEV_DEF_LONG_PRESS_TIME, didn’t help.
P.S.S. I’m on 8.3.3

SgtPepperFTW · December 21, 2023, 8:38pm

Ok, I found the issue. It is this line

github.com

lvgl/lvgl/blob/04d906a8514eb31cc45af38f0bc97055b2fd2f52/src/indev/lv_indev.c#L882


      
          }
          /*Pressing*/
          else if(data->state == LV_INDEV_STATE_PRESSED && last_state == LV_INDEV_STATE_PRESSED) {
              /*Long press*/
              if(i->long_pr_sent == 0 && lv_tick_elaps(i->pr_timestamp) > i->long_press_time) {
          
                  i->long_pr_sent = 1;
                  i->longpr_rep_timestamp = lv_tick_get();
          
                  if(data->key == LV_KEY_ENTER) {
                      bool editable_or_scrollable = lv_obj_is_editable(indev_obj_act) ||
                                                    lv_obj_has_flag(indev_obj_act, LV_OBJ_FLAG_SCROLLABLE);
          
                      /*On enter long press toggle edit mode.*/
                      if(editable_or_scrollable) {
                          /*Don't leave edit mode if there is only one object (nowhere to navigate)*/
                          if(lv_group_get_obj_count(g) > 1) {
                              LV_LOG_INFO("toggling edit mode");
                              lv_group_set_editing(g, lv_group_get_editing(g) ? false : true); /*Toggle edit mode on long press*/
                              lv_obj_remove_state(indev_obj_act, LV_STATE_PRESSED);    /*Remove the pressed state manually*/
                          }

In previous version that I was using, which was 8.0.2, this line was only checking if the object was editable. Now it checks if the object is scrollable, and since lv_scr_act() is of course scrollable by default my code goes in the branch of “toggling edit mode”