It seems a bug of the function "lv_obj_set_height_fit"

Bug (archived)
1

Description

I found “lv_obj_set_height_fit” call “lv_obj_set_width” , is it right?

What MCU/Processor/Board and compiler are you using?

none

What do you experience?

none

What do you expect?

none

Code to reproduce

void lv_obj_set_height_fit(lv_obj_t * obj, lv_coord_t h)
{
    lv_style_int_t ptop = lv_obj_get_style_pad_top(obj, LV_OBJ_PART_MAIN);
    lv_style_int_t pbottom = lv_obj_get_style_pad_bottom(obj, LV_OBJ_PART_MAIN);

    lv_obj_set_width(obj, h - ptop - pbottom);
}
2

Good catch; thanks! I’ve fixed it here: https://github.com/lvgl/lvgl/commit/81caeaa7253fdf76c1e1930a21bad4443428c2ba

3

Shouldn’t that be lv_obj_set_width(obj, h + ptop + pbottom)?
The WidthFit is supposed to be smaller than Width, isn’t it?